Skip to content

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 14, 2026

The PR enables compiling indexing extension with -fno-sycl-id-queries-fit-in-int option to support huge arrays.
Otherwise there will be an exception raised:

>       h_ev, choose_ev = indexing_ext._choose(inds, chcs, out, mode, q, dep_evs)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E       RuntimeError: Provided range and/or offset does not fit in int. Pass `-fno-sycl-id-queries-fit-in-int' to remove this limit.

The tests validating the change are placed in dpnp/tests/third_party/cupy/core_tests/test_ndarray_adv_indexing.py and can be enabled when running pytest with -m slow option.

Also a bunch of third party tests were updated to keep in sync with the latest content.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.20.0 release milestone Jan 14, 2026
@antonwolfy antonwolfy self-assigned this Jan 14, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2026

View rendered docs @ https://intelpython.github.io/dpnp/index.html

The tests were updated there to support run with pytest-run-parallel
@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2026

Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_51 ran successfully.
Passed: 1228
Failed: 1
Skipped: 7

@antonwolfy antonwolfy marked this pull request as ready for review January 14, 2026 13:59
@coveralls
Copy link
Collaborator

coveralls commented Jan 14, 2026

Coverage Status

coverage: 81.336%. remained the same
when pulling 558bb73 on indexing-to-work-with-huge-arrays
into dd9976d on master.

Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 9218f1c into master Jan 15, 2026
86 of 96 checks passed
@antonwolfy antonwolfy deleted the indexing-to-work-with-huge-arrays branch January 15, 2026 12:03
github-actions bot added a commit that referenced this pull request Jan 15, 2026
The PR enables compiling indexing extension with
`-fno-sycl-id-queries-fit-in-int` option to support huge arrays.
Otherwise there will be an exception raised:
```
>       h_ev, choose_ev = indexing_ext._choose(inds, chcs, out, mode, q, dep_evs)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E       RuntimeError: Provided range and/or offset does not fit in int. Pass `-fno-sycl-id-queries-fit-in-int' to remove this limit.
```` 9218f1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants